Skip to content

export client options#29

Open
ravener wants to merge 1 commit intofluxerjs:mainfrom
ravener:export-client-options
Open

export client options#29
ravener wants to merge 1 commit intofluxerjs:mainfrom
ravener:export-client-options

Conversation

@ravener
Copy link
Copy Markdown

@ravener ravener commented Mar 25, 2026 •
edited by coderabbitai bot
Loading

Description

Export ClientOptions and CacheSizeLimits, It's important to be able to access the ClientOptions when extending or modifying the client such as building another framework library on top of Fluxer.js, it is also exported in Discord.js

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the project's style guidelines (run pnpm run lint)
  • I have run pnpm run build successfully
  • I have run pnpm run test successfully

Summary by CodeRabbit

  • New Features
    • Core package now exports additional TypeScript types for client configuration and cache size limits, improving type safety and developer experience when configuring the library.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 25, 2026

@ravener is attempting to deploy a commit to the blstmo's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026 •
edited
Loading

Warning

Rate limit exceeded

@ravener has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0114c172-7f75-4b1a-9868-5698e1be246a

📥 Commits

Reviewing files that changed from the base of the PR and between 6e4d224 and d6745e1.

📒 Files selected for processing (1)
  • packages/fluxer-core/src/index.ts
📝 Walkthrough

Walkthrough

Re-exported two TypeScript types — ClientOptions and CacheSizeLimits — from ./util/Options.ts in packages/fluxer-core/src/index.ts, expanding the package's public type API surface without changing runtime exports.

Changes

Cohort / File(s) Summary
Type Re-exports
packages/fluxer-core/src/index.ts		 Added type-only re-exports: ClientOptions, CacheSizeLimits (forwarded from ./util/Options.ts).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I nibble at code with delight,

Types hop out into the light,
Options and caches, shared and bright,
A tiny export, just right.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: exporting the ClientOptions and CacheSizeLimits types from the public API.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ravener ravener force-pushed the export-client-options branch from f14a3a6 to 6e4d224 Compare March 25, 2026 12:54
coderabbitai[bot]
coderabbitai bot requested changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/fluxer-core/src/index.ts`:
- Line 86: The export line for the types ClientOptions and CacheSizeLimits uses
the .ts extension which is inconsistent with the other exports; update the
export source for those types (the export statement referencing ClientOptions
and CacheSizeLimits) to use the .js extension to match project convention and
avoid module resolution issues.
ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d1a38083-fbcb-4186-9d00-4e7136a42429

📥 Commits

Reviewing files that changed from the base of the PR and between 451d627 and f14a3a6.

📒 Files selected for processing (1)
  • packages/fluxer-core/src/index.ts

@ravener ravener force-pushed the export-client-options branch from 0238d1d to d6745e1 Compare March 25, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ravener